Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing foreign keys to fix #545 #549

Closed
wants to merge 4 commits into from
Closed

Add missing foreign keys to fix #545 #549

wants to merge 4 commits into from

Conversation

RMartinOscar
Copy link
Contributor

@RMartinOscar RMartinOscar commented Aug 14, 2024 •
edited
Loading

  • Make name & env_variables unique for each egg

Throws a 500 if you try to add a duplicate

@RMartinOscar RMartinOscar marked this pull request as draft August 14, 2024 18:31
Boy132
Boy132 requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@Boy132 Boy132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the backend changes we should also handle the frontend properly.

database/migrations/2024_08_14_182737_fix_egg_variable_foreign_key.php Outdated Show resolved Hide resolved
database/migrations/2024_08_14_182737_fix_egg_variable_foreign_key.php Outdated Show resolved Hide resolved
database/migrations/2024_08_14_182737_fix_egg_variable_foreign_key.php Outdated Show resolved Hide resolved
@RMartinOscar
Copy link
Contributor Author

@Boy132 sqlite tests are still failling

@Boy132
Copy link
Member

Boy132 commented Sep 6, 2024

@Boy132 sqlite tests are still failling

I found the reason: the sort for the bungeecord variables is null. For all other eggs the sort is filled.

@notAreYouScared
Copy link
Member

@RMartinOscar Can you merge main, and see if the tests pass?

@lancepioch
Copy link
Member

We should programmatically enforce this instead, I think sqlite has an issue with composite unique keys.

@lancepioch lancepioch closed this Oct 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Boy132 Boy132 Awaiting requested review from Boy132

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RMartinOscar @Boy132 @notAreYouScared @lancepioch